HIVE-29403: Move the truncate table out of HMSHandler #6269
Conversation
dengzhhu653
force-pushed
the
HIVE-29403
branch
from
b5a0a89 to
bf64176
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
dengzhhu653
force-pushed
the
HIVE-29403
branch
from
bf64176 to
e305e22
Compare
|
cc @wecharyu @saihemanth-cloudera could you take a look if have secs? thank you! |
dengzhhu653
force-pushed
the
HIVE-29403
branch
from
e305e22 to
0daab9d
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
...tastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/JavaUtils.java
Outdated
Show resolved
Hide resolved
...re-server/src/main/java/org/apache/hadoop/hive/metastore/handler/AbstractRequestHandler.java
Outdated
Show resolved
Hide resolved
| Class<? extends TBase> requestBody(); | ||
| boolean supportAsync() default false; | ||
| String id() default "getId"; | ||
| String cancel() default "isCancel"; |
There was a problem hiding this comment.
id and cancel is from request, it seems a little strange to set get such annotations for handler.
There was a problem hiding this comment.
when creating the handler, it knows what the request is, and how to get the async id from the request at the definition.
| private Future<Result> executeRequest() { | ||
| Timer.Context timerContext; | ||
| if (StringUtils.isNotEmpty(getMetricAlias())) { | ||
| Timer timer = Metrics.getOrCreateTimer(MetricsConstants.API_PREFIX + getMetricAlias()); |
There was a problem hiding this comment.
will multi reflection calls affect the performance?
There was a problem hiding this comment.
it's just a simple call, no reflection here
| } finally { | ||
| super.afterExecute(result); | ||
| if (async) { | ||
| rs.shutdown(); |
There was a problem hiding this comment.
why cleanup rs here? it will be cleaned if connection is closed in HMSHandler.cleanupHandlerContext().
There was a problem hiding this comment.
no, if this handler is running in background thread, HMSHandler.cleanupHandlerContext() will just clean the main thread which creates this backed thread.
| } finally { | ||
| super.afterExecute(result); | ||
| if (async) { | ||
| ms.shutdown(); |
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
|
3 participants
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?